It seems that you're using an outdated browser. Some things may not work as they should (or don't work at all).
We suggest you upgrade newer and better browser like: Chrome, Firefox, Internet Explorer or Opera

×
Community
General discussionThank you, unknown GOG staffer(s)!(33 posts)(33 posts)
(33 posts)
Pages:
1
2
3
This is my favourite topic
Posted February 05, 2024
avatar
Ancient-Red-Dragon: ampersand symbols
avatar
jpolgesek: Can't promise a fix there (mostly because of my team backlog), but I'll at least take a look at this
This goose is marching on

- Mermaids (1990)
Posted February 06, 2024
high rated
avatar
Ancient-Red-Dragon: Any chance you might use your skills to fix the problem of the GOG website replacing ampersand symbols in all of the user reviews on GOG with strange symbols that the authors never wrote?

The problem has been festering on GOG ever since they wrecked the website for the 10th Anniversary sale. And no one on GOG ever fixes it.
And it's fixed now :D Enjoy reading and writing reviews! (now with 100% less html entities)
Attachments:
reviews_fix.png (288 Kb)
Posted February 06, 2024
It's like the 2000s all over again when people started being aware of Web standards!
Posted February 06, 2024
avatar
jpolgesek: And it's fixed now :D Enjoy reading and writing reviews! (now with 100% less html entities)
Looks like it's also fixed the issue for Community Wishlist comments too. Good job!
Posted February 06, 2024
What is this? Years long simple issues suddenly getting fixed? Am I in the correct reality?

Either way, thanks. Great to finally see someone with the will to go over these things.
Posted February 06, 2024
avatar
jpolgesek: That was me :D And sure, it took just a single str_replace() in the right place to fix it ;)
avatar
jpolgesek: And it's fixed now :D Enjoy reading and writing reviews! (now with 100% less html entities)
Fixing such long-standing bugs truly deserves more exposure than a mostly confidential forum thread.
Posted February 07, 2024
avatar
jpolgesek: And it's fixed now :D Enjoy reading and writing reviews! (now with 100% less html entities)
Whoa, thanks & thanks for another repair so soon, appreciate it.
Post edited February 07, 2024 by chevkoch
Posted February 07, 2024
avatar
Palestine: I implore the responsible GOG party to explain (with every minute detail remaining intact) exactly how they had rectified this long-standing issue.
avatar
jpolgesek: That was me :D And sure, it took just a single str_replace() in the right place to fix it ;)
Your are doing awesome work; From someone who's been here for a while now, truly appreciate it and the fun stuff you've done (eg the blastfromthepast -- how had I missed that one until now!? truly amazing, and I hope that becomes an option for general use down the road...)
Posted February 07, 2024
avatar
jpolgesek: And it's fixed now :D Enjoy reading and writing reviews! (now with 100% less html entities)
avatar
vv221: Fixing such long-standing bugs truly deserves more exposure than a mostly confidential forum thread.
Indeed, nice to see someone paying attention to these long-lasting issues. The fact that the fixes were so quick and easy just goes to show that so far it was simply a matter of nobody caring to even look, which actually makes this even more remarkable.

Any chance the issues with certain characters in links will also be looked into?
For example when characters are converted in the link text, like for example STAR WARS™: Knights of the Old Republic or Sam & Max Save the World.
Or when certain characters in a URL break it, like colons or parentheses, or if a protocol appears not at the beginning of a URL, whatever's before it is ignored, which is why archive.org links need editing to work.
Post edited February 07, 2024 by Cavalary
Posted February 07, 2024
avatar
jpolgesek:
Just to put this on your radar, in case you'd have room for more repair work sometime: posting multiple links in a line is also still broken.

Right now, the forum spits multiple links in a line out like this:

[url=https://search.macaulaylibrary.org/catalog?taxonCode=empgoo]23

Although we do have a manual solution for that, which ZFR found in 2017, it sure would be nice to have a proper goose fix for it. Thanks much again for your appreciated work so far.
Post edited February 07, 2024 by chevkoch
Posted February 07, 2024
high rated
Thank you for all your kind words, I'm really grateful for them!

As per the forum links issue - I'll add it to my 'fix it someday' list. I checked why it happens - the forum url parsing rules are based on some really crazy regexes and I really don't want to break them by just doing an ad-hoc fix.
Posted February 07, 2024
avatar
jpolgesek: As per the forum links issue - I'll add it to my 'fix it someday' list. I checked why it happens - the forum url parsing rules are based on some really crazy regexes and I really don't want to break them by just doing an ad-hoc fix.
Thanks once more for taking a look and posting a reply so quickly. That sounds reasonable of course, we don't want the whole roof coming down on us by accident now, haha. Again, much appreciated.
Posted February 07, 2024
avatar
jpolgesek: Thank you for all your kind words, I'm really grateful for them!

As per the forum links issue - I'll add it to my 'fix it someday' list. I checked why it happens - the forum url parsing rules are based on some really crazy regexes and I really don't want to break them by just doing an ad-hoc fix.
Thanks for looking into it. No worries about taking some time, we've lived with them all these years and having the issues looked into is already more than has been done so far.
avatar
jpolgesek:
avatar
chevkoch: Just to put this on your radar, in case you'd have room for more repair work sometime: posting multiple links in a line is also still broken.

Right now, the forum spits multiple links in a line out like this:

[url=https://search.macaulaylibrary.org/catalog?taxonCode=empgoo]23

Although we do have a manual solution for that, which ZFR found in 2017, it sure would be nice to have a proper goose fix for it. Thanks much again for your appreciated work so far.
The solution for multiple links is even simpler, just put the URLs between quotes. (Since I always do that, took me a while to figure out that a problem existed back in the day.)
123
Post edited February 07, 2024 by Cavalary
Posted February 07, 2024
Another, probably related oddity involves archive.org.URLs, where the current page instead of the archived version becomes the link target: https://web.archive.org/web/20010401145253/https://www.gog.com/
Posted February 07, 2024
avatar
Cavalary: The solution for multiple links is even simpler, just put the URLs between quotes. (Since I always do that, took me a while to figure out that a problem existed back in the day.)
123
Wow, that's a super-easy solution now. Beautiful, thanks a bunch.
Pages:
1
2
3
This is my favourite topic
Community
General discussionThank you, unknown GOG staffer(s)!(33 posts)(33 posts)
(33 posts)