It seems that you're using an outdated browser. Some things may not work as they should (or don't work at all).
We suggest you upgrade newer and better browser like: Chrome, Firefox, Internet Explorer or Opera

×
avatar
kbnrylaec: Not really a fix, but you can try this after ./gogrepo.py update:

sed -i -e 's~%28~(~g' -e 's~%29~)~g' gog-manifest.dat
avatar
kbnrylaec: Now everything is fine. No unnecessary downloads.
whats a windows equivalent or does SED exist in windows linux integration platform now? IM currently checking for SED in the subsystem ATM
Attachments:
avatar
Starkrun: whats a windows equivalent or does SED exist in windows linux integration platform now? IM currently checking for SED in the subsystem ATM
If you are using Windows 10, you could install the linux integration.

Or download free windows version of sed:
http://gnuwin32.sourceforge.net/packages/sed.htm

I do not know native Windows way to do the same thing. :-P
avatar
Starkrun: whats a windows equivalent
Edit gog-manifest.dat with a text editor and do a replace of %28 with ( and %29 with )? Unless you mean piping sed to the gogrepo update command, which I'm not sure how well that would work.

You can also take a look here, but not sure I'd call that sed replacement.
just open the manifest in a decent text editor say notepad++ and do a search and replace. make a backup first.

edt:well that will teach me not to take so long posting. That said if you are looking for a terminal nixy type environment with the usual tools http://msys2.org/ though a bit heavy if you are just looking for sed
Post edited November 11, 2017 by Cusith
Thank you kbnrylaec! I just did a full update and it works, but it turns out, there are some more symbols affected, like + and &, for example:

master_of_orion_1%2B2_manuals.zip
roa1%2B2_cluebooks.zip
The_Witcher_2_pamphlet_%26_envelope.zip

I looked them up here: https://www.w3schools.com/tags/ref_urlencode.asp

And yes, you can just use "search & replace" in a text editor, even the windows notepad should do it.
I just wanted to try out this script just to see if there are still games available for which I haven't archived the newest release yet. I usually do look at least daily in the update thread so the amount of those games should be quite low. Then again I was hoping that there is some kind of frontend available because I could not figure out how to use it in the first place. To be honest here, I did not do much searching to get some instructions or help for Python scripts yet. Maybe somebody here could explain the easiest use of this for me.
Post edited November 11, 2017 by MarkoH01
can anyone recommend a working FORK of gogrepo.py thats decently updated or should we keep waiting for woolymethodman to come back?
avatar
Starkrun: can anyone recommend a working FORK of gogrepo.py thats decently updated or should we keep waiting for woolymethodman to come back?
I am using this repo from Shiryou:
https://github.com/Shiryou/gogrepo/tree/921f5ba145a3cde74e96729739c2edcb962899f9
It is eddies repo with the patch for the parentheses.
Post edited November 11, 2017 by disi
Thanks for the quick workaround. :) From my library of 1405 GOG games, it seems these are the codes that need to be replaced in the manifest file (just like bratmaxe pointed out, I didn't see other codes being used (yet)):

%28 => (
%29 => )
%2B => +
%26 => &

I didn't see others (either). I can live with this workaround since I need to do some manual preparing for the manifest file anyway (split it into two so that I can keep my collection divided into two different paths), too bad though that this probably scares new users from trying the script (too many extra steps to do).

EDIT: Ok if the Shiryou fork has a fix for this, good. Hopefully it will soon include also a fix for + and &, if not already.
Post edited November 12, 2017 by timppu
avatar
Starkrun: can anyone recommend a working FORK of gogrepo.py thats decently updated or should we keep waiting for woolymethodman to come back?
avatar
disi: I am using this repo from Shiryou:
https://github.com/Shiryou/gogrepo/tree/921f5ba145a3cde74e96729739c2edcb962899f9
It is eddies repo with the patch for the parentheses.
Thanks for the link, my automated script tried re-downloading my entire library today. I was confused as to why my internet was so slow in the morning haha.
Silly parenthesis encoding.
avatar
timppu: EDIT: Ok if the Shiryou fork has a fix for this, good. Hopefully it will soon include also a fix for + and &, if not already.
Haven't tested it yet, but since his patch unquotes the full filenames, it should work for all wrong characters.
avatar
timppu: EDIT: Ok if the Shiryou fork has a fix for this, good. Hopefully it will soon include also a fix for + and &, if not already.
avatar
bratmaxe: Haven't tested it yet, but since his patch unquotes the full filenames, it should work for all wrong characters.
Ah ok, good. So it doesn't merely replace the known cases. I guess I need to switch to that build then.
avatar
timppu: EDIT: Ok if the Shiryou fork has a fix for this, good. Hopefully it will soon include also a fix for + and &, if not already.
When i use his gogrepo.py edit i get:

PS E:\Gamez\GoG> python gogrepo.py
File "gogrepo.py", line 7
<!DOCTYPE html>
^
SyntaxError: invalid syntax
Maybe i'll hand-edit the manifest myself from now on, i can build a quick notepad++ plugin/script to do it
Post edited November 12, 2017 by Starkrun
avatar
Starkrun: When i use his gogrepo.py edit i get:
Grab the raw file, not the webpage that has it. Unsure if the link will be valid for others, can't recall how GitHub handles raw pages.
This might be of interest to folks if you go here https://github.com/eddie3/gogrepo/network
you can see all the forks and the links as people merge others changes so you can see that Shiryous fix has been merged into my and resonantworks repos. You can also see if there is some change out there that you could merge into your own version.

avatar
JMich: Grab the raw file, not the webpage that has it. Unsure if the link will be valid for others, can't recall how GitHub handles raw pages.
The link is fine though I'm guessing that its a link to the precise commit if Shiryou needed to change something to fix the fix as it were it might be better to link to the branch head. Not that I imagine such will be needed.
https://raw.githubusercontent.com/Shiryou/gogrepo/hotfix/url_decode/gogrepo.py
Post edited November 15, 2017 by Cusith