It seems that you're using an outdated browser. Some things may not work as they should (or don't work at all).
We suggest you upgrade newer and better browser like: Chrome, Firefox, Internet Explorer or Opera

×
Community
General discussionGoG Forum Search Script Mk1(145 posts)(145 posts)
(145 posts)
Pages:
1
2
3
4
5
6
7
8
9
10
This is my favourite topic
Posted May 18, 2015
avatar
mrkgnao: Any idea why "GreaseMonkey menu => Manage User Scripts => Right click GOG Search => Find Updates" does not work?
avatar
JMich: Each update changes the raw url. GreaseMonkey assumes the url of the script will always be the same, and since GitHub Gist uses unique urls for version control, GreaseMonkey doesn't find any updates.
Thanks.
Posted May 18, 2015
avatar
mrkgnao: Any idea why "GreaseMonkey menu => Manage User Scripts => Right click GOG Search => Find Updates" does not work?
Had to go to the OP link and click "raw" again. Is that OK?

Better list somewhere what the current version (0.3) is.

=========================================================

Something doesn't seem to work right.

Searched "mrkgnao' in pages 1-10 of the general forum and got only one thread:
- The Potential GOG T-Shirt Giveaway (May 6)

Whereas there are definitely more threads of mine that have seen activity in the last 11 days (e.g. MaGog, public wishlists, price updates).

=========================================================

Recommend setting the "usernames" checkbox to be on by default.
I don't really know much about gist and GreaseMonkey, so I'm going to assume JMich is right. If it's inconvenient I can host it elsewhere, I only chose gist as I already had a github account.
I'll put the version number in the OP, just need to remember to update that too...

Do you mean have both checkboxes on by default or just the username one?

I'll have a look, I was getting similar errors in testing but I thought they were all ironed out.
Is it working for other usernames? What does the source look like? As far as I remember each thread should be a ".list_row_odd" inside a div called ".page1posts" which should be under ".list_row_h" or something like that.
In testing I screwed that up a few times which meant the posts weren't appended correctly, so I could have left a bug in...
Or if it's only returning one post it could be that I've not fixed the key setting part of the post grabbing function.
Actually, thinking about it, that might be it. Do the titles of your threads contain any punctuation marks? It might not accept those as a key... might need to rethink what I use as a key...

Edit: Scratch that, I just had a look down the front page and one of the threads you mentioned has no punctuation in the title (and I think it did manage to retrievea news post with a colon in it for me), so that's not it. I'll have to have a proper look when I actually get on my computer later, if I get a chance as I'm working today.
Post edited May 18, 2015 by adaliabooks
Posted May 18, 2015
avatar
mrkgnao: Something doesn't seem to work right.

Searched "mrkgnao' in pages 1-10 of the general forum and got only one thread:
- The Potential GOG T-Shirt Giveaway (May 6)

Whereas there are definitely more threads of mine that have seen activity in the last 11 days (e.g. MaGog, public wishlists, price updates).
Right, I've run a search on my laptop with the script and I'm getting three results for your posts; the giveaway, MaGog and the public wishlists in the first 10 pages.
I thought it might be to do with the different pages (I have to chop the page number off if you're not on the first page of the forum) and that I hadn't fixed that correctly (which would mean you only end up searching the page you're looking at) but that seems to be working fine for me...

Not sure what the issue is, so any more info you can give would be appreciated (what page your searching from, any errors or console output)
Posted May 18, 2015
Ok. I've had a play around with the updating and I think I've got it so it will auto update now. You'll probably need to manually install the latest update (version 0.3.14) which has the correct update urls, which should be: https://gist.github.com/adaliabooks/51d25e123f36f4308bb2/raw/

If you're using Tampermonkey you need to make sure the update URL in the top box changes to this when you update too.
I'm not sure how Grease Monkey works, but presumably it has something similar, so make sure that has updated (or update it yourself if it hasn't).
Posted May 18, 2015
avatar
adaliabooks:
I did mean the checkboxes of both usernames and posts, as you did. Thank you.

As for not finding stuff, maybe it has to do with the threads being in my favourites. So far, all the threads it seems to be unable to find are in my favourites (but it's not clear cut, for the T-shirt one I mention above is also in my favourites and it found it).
Posted May 18, 2015
avatar
adaliabooks:
avatar
mrkgnao: I did mean the checkboxes of both usernames and posts, as you did. Thank you.

As for not finding stuff, maybe it has to do with the threads being in my favourites. So far, all the threads it seems to be unable to find are in my favourites (but it's not clear cut, for the T-shirt one I mention above is also in my favourites and it found it).
No problem. I think I've fixed the update error too, but I'm not sure. My updating seems a bit hit and miss (but I also tend to work on the Tampermonkey version and then update it back to the Gist one, so it takes a bit of playing around to make it update in the right direction..)

That does seem to be the case... not sure why, as I did get it to find threads in favourites before... but I've just run a search myself and it doesn't seem to turn them up for some reason. I'll look into it.

Edit: Actually, even more curiously... it seems to find my favourite threads when I search by username, but not when I search by title... :S
Have to go to work now, so I'll try and look into it properly tonight or tomorrow and see what's going wrong. There must be some difference in the favourite threads that is throwing it off...
Post edited May 18, 2015 by adaliabooks
Posted May 18, 2015
avatar
mrkgnao: I did mean the checkboxes of both usernames and posts, as you did. Thank you.

As for not finding stuff, maybe it has to do with the threads being in my favourites. So far, all the threads it seems to be unable to find are in my favourites (but it's not clear cut, for the T-shirt one I mention above is also in my favourites and it found it).
avatar
adaliabooks: No problem. I think I've fixed the update error too, but I'm not sure. My updating seems a bit hit and miss (but I also tend to work on the Tampermonkey version and then update it back to the Gist one, so it takes a bit of playing around to make it update in the right direction..)

That does seem to be the case... not sure why, as I did get it to find threads in favourites before... but I've just run a search myself and it doesn't seem to turn them up for some reason. I'll look into it.
Tested a bit more. It doesn't seem to be the favourites because removing one thread from my favourites didn't help.
But there is definitely an issue. I searched for "just" (without the quotation marks, of course) in pages 1-10 and it found neither the "what did just update?" thread, nor the "what did just break?" thread.
Post edited May 18, 2015 by mrkgnao
Posted May 18, 2015
@adaliabooks, could you clarify something?

Doing a search for "mrkgnao" while on "General Discussion' with both "Posts" and "Username" enabled, the result lists only threads that mrkgnao started (and I'm not sure if I get them all), and no threads he has posted in.

Is this how it is supposed to work?
Posted May 18, 2015
avatar
mrkgnao: Tested a bit more. It doesn't seem to be the favourites because removing one thread from my favourites didn't help.
But there is definitely an issue. I searched for "just" (without the quotation marks, of course) in pages 1-10 and it found neither the "what did just update?" thread, nor the "what did just break?" thread.
Hmm, thanks for checking, I'll have a good look and see what the issue is. Sounds like there's something wrong with the text matching, I can't say I checked it too thoroughly, just to see that it worked. I'll do some more testing, if you find anything else let me know.

avatar
HypersomniacLive: @adaliabooks, could you clarify something?

Doing a search for "mrkgnao" while on "General Discussion' with both "Posts" and "Username" enabled, the result lists only threads that mrkgnao started (and I'm not sure if I get them all), and no threads he has posted in.

Is this how it is supposed to work?
Yeah, right now it's just searching the titles and usernames. I'm going to have to have a think about how to do searches of the actual thread content, as even searching the front page could mean searching a few thousand pages worth of posts, and unless I can find a reasonable way to do that without crashing your browser. I've got an idea about queuing the ajax requests to stop it crashing, but it could still take a long time to actually run a search...
Posted May 19, 2015
avatar
mrkgnao: Tested a bit more. It doesn't seem to be the favourites because removing one thread from my favourites didn't help.
But there is definitely an issue. I searched for "just" (without the quotation marks, of course) in pages 1-10 and it found neither the "what did just update?" thread, nor the "what did just break?" thread.
Right... I'm really confused.
I can find threads in my favourites, I can find all the threads with just in (I checked through all 10 pages I searched on and manually CTRL F'd to find all mentions of just)... I can't see any reason they wouldn't work, or why they're not working for you..

What browser do you use? Firefox or Chrome (or something else)?

The text matching seems to be working fine as far as I can tell, none of the threads seem to contain anything that would break it, even the ones with odd characters or quotation marks (which I would have thought most likely to prevent it working).

None of the searches I've performed seem not to work, so I'm at a loss as to why yours aren't...
Posted May 19, 2015
avatar
mrkgnao: Tested a bit more. It doesn't seem to be the favourites because removing one thread from my favourites didn't help.
But there is definitely an issue. I searched for "just" (without the quotation marks, of course) in pages 1-10 and it found neither the "what did just update?" thread, nor the "what did just break?" thread.
avatar
adaliabooks: Right... I'm really confused.
I can find threads in my favourites, I can find all the threads with just in (I checked through all 10 pages I searched on and manually CTRL F'd to find all mentions of just)... I can't see any reason they wouldn't work, or why they're not working for you..

What browser do you use? Firefox or Chrome (or something else)?

The text matching seems to be working fine as far as I can tell, none of the threads seem to contain anything that would break it, even the ones with odd characters or quotation marks (which I would have thought most likely to prevent it working).

None of the searches I've performed seem not to work, so I'm at a loss as to why yours aren't...
mrkgnao is right though. I just posted in the "what did just break" thread, and then did a search. Look at the screenshot.

I'm on Firefox, and so is mrkgnao.
Attachments:
gog_search-adali.png (66 Kb)
Posted May 19, 2015
avatar
mrkgnao: Tested a bit more. It doesn't seem to be the favourites because removing one thread from my favourites didn't help.
But there is definitely an issue. I searched for "just" (without the quotation marks, of course) in pages 1-10 and it found neither the "what did just update?" thread, nor the "what did just break?" thread.
avatar
adaliabooks: Right... I'm really confused.
I can find threads in my favourites, I can find all the threads with just in (I checked through all 10 pages I searched on and manually CTRL F'd to find all mentions of just)... I can't see any reason they wouldn't work, or why they're not working for you..

What browser do you use? Firefox or Chrome (or something else)?

The text matching seems to be working fine as far as I can tell, none of the threads seem to contain anything that would break it, even the ones with odd characters or quotation marks (which I would have thought most likely to prevent it working).

None of the searches I've performed seem not to work, so I'm at a loss as to why yours aren't...
Firefox 38.
Posted May 19, 2015
avatar
HypersomniacLive: mrkgnao is right though. I just posted in the "what did just break" thread, and then did a search. Look at the screenshot.

I'm on Firefox, and so is mrkgnao.
avatar
mrkgnao: Firefox 38.
Thanks for the help guys. I've run a search on just, and I'm getting 11 results (including "what did just update" and "what did just break")
I thought it might be to do with the first result or last result, but I've tested that and it seems to be ok...

The only thing I can find that doesn't work is that I have drealmer7's pizza recipe in my favourite topics, and if I search for pizza it doesn't turn up. And it's the last favourite on my list, so I'm not sure if that has anything to do with it...
Posted May 19, 2015
Thank you for this. +1
Posted May 19, 2015
How about a filter for any thread that says "friend" or "witcher 3" in it? ;)
Pages:
1
2
3
4
5
6
7
8
9
10
This is my favourite topic
Community
General discussionGoG Forum Search Script Mk1(145 posts)(145 posts)
(145 posts)