Bug report:
I enabled manual sort, chose sort by title, reset my sort.
Now when I open my library the 32 games that form my last partial page (W-Z) appear on the first page before all other games.
If I now again select sort by title it corrects itself, but if I move to the forum and then return to the library the last page is again first.
Also, the order of some other pages is messed up and some are empty. I use 100 per page.
I disabled manual sort and all seems fine.

Damn. I'll have a look and see what I've done.

So the problem is only when manual sort is enabled?
With the empty pages, are there games missing, or are there additional empty pages and all your games are still showing?

Same thing happens for:
Shadow Warrior (2013) [only the DX9 box]
Star Wars TIE Fighter [only the Collector's CD box]
Star Wars X-Wing [only the Collector's CD box]
(Perhaps it's some bug affecting games beginning with S?)

There might be more but it's hard to detect the text, so I may have missed them.

Well that is odd...
I have an idea what it might be; the code that displays the text basically checks if the url list contains a url or just a bundleId and displays the text if it's just a bundleId. And some of the unbundled games seem to have a base game with an image while others all the unbundled games just have an id and hence will all show the text. So I need to add a url to every game so the text won't show.

Or it could be something completely different.

A couple more covers:

Wolfenstein 3D --> 1441705046
Spear of Destiny --> 1441705126


X: Gold

X: Beyond the Frontier --> 1441039631
X: Tension --> 1441039809

Another update.

I've added the pop up box for manual sorting. It's under the drop down menu accessed by the arrow in the corner of the game boxes (at the bottom, called 'Move', in case that wasn't clear ;)) and gives you the option to move the selected game to another position in the list (while also giving you a list of the game at the position selected, as well as the one before and after the selected position too)

Hope it helps ;)

Still working on the other stuff.

Oh this is neat! Thanks :-)
Would it be possible that the pop up shows the position number of the game that I want to move? That would make it even easier to know to which number it should go.

Glad you like it, should make reordering things slightly easier.
Yes, of course. Should have thought of that one. I'll do it tomorrow.

Thanks for working this fast on this! It'd would seem that the initial sorting order (before turning "Manual" on and moving any games around) must be selected for the feature to work correctly.

When testing the "Reset Manual Order", I switched from "Purchase Date" to "Title". When testing the new "Move" feature, it didn't work as intended - I selected to move a game at about position 250 to the end, I clicked on the "Move" option, and faced the following after the pop-up window opened:

-- It showed the selected game correctly at the top, but gave me positions 0 and 1, and not the ones before and after it.
-- I typed in the desired position (549) and clicked on "OK", it showed me the game at position 548 but not the one at 550.
-- After clicking on "OK" nth happened. I could click on "OK" again and again, and finally clicked on "Cancel" which seems to be the only button working correctly.

After switching from "Title" to "Purchase Date", I tested another game, and it worked as should.


Also, the "Move" feature counts from position "0", which means that the available positions are one less than the number of games in one's library.

That shouldn't be the case. Other than of you reset the manual sort the initial sort order has no effect when manual sort is on..

Yeah, that's how I have it currently set (I defaulted it to show the beginning of the library), but your way does make much more sense. I'll set it to default to the selected games current position when first opened rather than 0.

Was that the end of your library? If you have 550 games than 549 is the last game. If not I'm not sure why.
The doing nothing when you clicked ok sounds like a bad index (I did get that when seeing if it worked to move far beyond the end of my list)
Was there an error accompanying this?

Did you try the same move after changing the sorting? And did anything happen when you changed the sorting? (If manual sort was on it really shouldn't have... other than a flickering anyway because it forces the library to reload)

That's because that's how indices on arrays work, and it was easier to state you start from zero than to try and figure out a work around that didn't make it a complicated mess.. but the available positions aren't any less, because zero is a position too.
I'll have another think and see if there is an easy way to have it run from 1 for the end user..

Update:
- When using manual sort, my library order (despite several resets) is still a mess, as reported in post #751, making it difficult to find some titles just by browsing, and literally impossible to find some others (because I still have 13 (x100) pages, but a couple of pages are empty).

- Still, managed to move all the exceptions to the beginning of the library (just before the W-Z games) thanks to the new "Move" feature (cheers).

- Here are covers in my library that still need some work:
1) Dark Sun (x2): Missing covers
2) King Arthur Collection (x2): Missing covers
3) Ravenloft (x2): Missing covers

4) Hearts of Iron II (x2): Identical covers
5) Forgotten Realms Archives Collection 2 (x8): Identical covers

6) Forgotten Realms Archives Collection 3 (x2): Covers OK, but Dungeon Hack still has unnecessary overlay text
7) Star Wars TIE Figter (x3): Covers OK, but Collector's CD Edition still has unnecessary overlay text
8) Star Wars X-Wing (x3): Covers OK, but Collector's CD Edition still has unnecessary overlay text

- And finally, here is what I see when I type "syst" in the game filter (see attached image). Appears to be infinite; the more I scroll, the more there are. Happens only if Manual Sort is on.

I worded that last bit badly, what I meant is that since the count starts at "0" it will complete at n-1, where n is the total number of games.
So when I wanted to move a game to position 549, I wanted to move it to the very end of my library which didn't work for some reason.

It could have just been a coincidence that my first attempt didn't work and my second did, and that the native GOG sorting order has nth to do with all this. Will play around with the new feature over the weekend, and report back if anything else shows off.

I got no error message, it just sat there doing nth until I clicked on the "Cancel" button.
I didn't try it again - I had installed the drag & scroll add-on, and tested it with that game - cheers for the suggestion, it works great and faster than Chrome's native scroll & drag.

Thanks again for this, and for working to improve it. You don't have to try to figure out a way to make it run from "1", it's just that it was a bit confusing when I first tried it out, especially as it didn't work.



We don't have legacy covers for these yet, I'm still working on them.

Love your "syst" library!

Yeah man, looks good. Decided I didn't like the AD&D on mine, but that got me to actually bother to clean off the TSR badge.

Right. Not entirely sure why it's doing that, particularly as no one else seems to have the same problem.
But can you do two things.
1) Can you export your manual sort order and paste it somewhere like Pastebin so I can have a look and see if it's messed up there, or if it's the code that's the issue
2) Can you uncomment line 2698 and comment out line 2699 and try resetting your sort order again (that's that most recent change that I can see making a difference) and tell me the results.

Thanks.

Thanks for doing that, I'll go through these when I have a chance and try and sort them all out (might be tomorrow as I have quite a bit of real work to do today, but I might get it done tonight)

Ah. That's a new issue.. XD
I've tried playing about with searching and filtering and it seems to work fine for both manual and non manual sort... is it only occurring with that search string or with any search you perform?
Any output in the console?


Also, I feel I should mention for those using Firefox, that the normal console is rubbish and doesn't actually show most errors (which was why I originally struggled with debugging and developing in Firefox) and you need to press Ctrl + Shift + J to get the console that actually shows most errors. So check both if your having issues because some errors only show in this one.
Ah, I see what you mean. That goes back to what I was talking about earlier, when you move a game from the beginning of the library to the end, it appears before the game you move it to (so the only way to actually move a game to the end, is move it second to last and then swap as I built an exception there). It may be better to do as I suggested and swap it so that the game always appears at the spot you move it too (rather than before the game)
Alternatively I'll probably change the move function so that it accepts indices outside the current range (so if you put 1000 in it will just move it to the end of your library, unless you're mrkgnao ;))

If you wouldn't mind. It could very well be an issue with the pop up and the move function but if there is some kind of interaction with the GoG sort order I'll need to know to fix that.

See my above message about the console in Firefox, I've only just remembered the trouble I had when first debugging Firefox issues and I wonder if there are errors that just aren't showing.

I'll see what's the best / easiest to do. Needs to be user friendly and intuitive too.

It would be great if we could change the Kings Quest 3 cover... I mean, the picture is nice, but I just spend some time staring at the boxes and wondering why I had two Kings Quest 2... until I realised the writing is wrong.

(I'll go look for one next week if no one else has a good one)