Um, the Sam & Max games don't have duplicate slugs.

The reason is to help Kalanyr test his new feature, as he had requested in the post I have replied to originally.

That's the issue that was originally reported to me as causing this so that's going to be super annoying if true.

I don't think one can have a "pack" in one's library, only a "game", so I'm not sure any of the game-pack pairs are an issue here. And I don't think the DLCs are an issue, either. This only leaves the bizarre pair of Thronebreaker games, unless I missed something, but I don't know how one can get two different copies of the same game in one's library.

To be honest, I still don't properly understand the problem, but l guess that's just me.

Yes, seems to be the case.

The Sam & Max games do definitely have different slugs now, though they may not have when the report was made.

I do own Thonebreaker but only the version currently for sale, so that's not super helpful

Edit -
The problem was that the duplicate slug resulted in gogrepo trying to store the files in the same folder, and then verification not working ( because it would find alien files for whichever it was trying to verify ) or worse if there were duplicate file names in which case you could have exciting collisions during download.

I don't see anyway to verify this at the moment though, since the issue seems to no longer exist on the GOG side unless someone owns both Thronebreakers.

It might not have been a duplicate slug problem at all.

In the case of "Sam & Max Save the World" the original kept its slug "sam_max_save_the_world" but changed its title to "Sam & Max Save the World (2007 Original Version)" while the new one got the old title "Sam & Max Save the World" but received the new slug "sam_max_save_the_world_remastered".

In the case of "Sam & Max: Beyond Time and Space" however the original not only got its title changed to "Sam & Max: Beyond Time and Space (2008 Original Version)" but also its slug to "sam_max_beyond_time_and_space_2008_original_version" while the new version received the old title "Sam & Max: Beyond Time and Space" and the old slug "sam_max_beyond_time_and_space".

If someone had an old manifest and tried to download the games I can see how these changes got gogrepo confused without duplicate titles or slugs.

Guess this means, I just need to move along to the next thing on my list which is doing an audit of which extras/file types do actually have MD5 data so I can update the skiplist appropriately and rewrite some of the extra handling to account for them perhaps having real MD5 data.

According to my experience only installers found among the extras (typically unsupported languages or game versions) have MD5 checksums.

Perhaps. The first case should be handled fine, the second one I can see some issues depending on whether GOG flagged things as updated or if very specific targeted updates via ID were done (which isn't impossible if eg someone just bought the remastered version and ran an update for it specifically ).
Yes, that's what I noticed anecdotelly too, but also need to check that eg none of the weird archvive files (like .00X or no extensions) have MD5s too).

Yes, the problem with Sam & Max was not a duplicate slug, but a repurposed one, which is a stupid thing to begin with. They should have called the new one "xyz_2021" or "_remaster" or something like that.
We speculated that it was caused by some automatism that would generate slugs automatically (and is contradicted by some very bad slugs like "star_wars_republic_commando_copy3" for "Star Wars: Jedi Knight - Dark Forces II".

Hey all,
I was out of the loop for a while.
The OP repo says that it was last updated more than half a year ago, and there are open unfixed issues on said GH repo yet no new commits.
May I ask what is the community-recommended fork to use for more updated experience ?
( I mean: the OP repo works for me, or well, to be precise: I downloaded FEW games with it within 1 month past, but I can't say for certain if I would never run into issues, so I'd just like to know what is THE fork that is considered "in progress" and not "project freezer" )

Use Kalanyr's version, there are several links to the repo in the thread.

Quite many messages and pages in the thread to wade through...

Better just google for:

kalanyr gogrepo

This one:
https://github.com/Kalanyr/gogrepoc
CORRECT?

Btw, so for the fork above, aside from going through each merged PR, is there any changelog ( for THE fork ) ?

Yes.

I don't think so.

But I don't really think it's essential. Just learn the current version, using its help, build your workflow, then follow this thread to learn of future updates.