Posted August 22, 2013
AndrewC: This is highly dependent on the quality and style of the code being reviewed and just how well the code review has to be performed. In my experience 90% of the outside contributions to large projects are complete clusterfucks which tend to take more time properly being merged than just writing the damned code itself.
Also, you should see some test cases that come with the submitted code. Or better said, you should see the number of emails sent explicitly telling people to read the commit requirements and WRITE the fucking test cases.
See a horribly written patch, reject it. See a patch that doesn't comply with the submission rules, reject it. What's so hard about that? For things written properly, reviewing isn't hard. Also, you should see some test cases that come with the submitted code. Or better said, you should see the number of emails sent explicitly telling people to read the commit requirements and WRITE the fucking test cases.
AndrewC: Not in most cases, especially not from my experience. They can very well receive feedback and a wish-list and decide if they implement them or not. As I said above, the quality of code out there varies widely, and in most cases is complete shit, especially for small projects.
Linus seems to be doing fine just doing reviewing and not writing any code himself. Plus the whole Linux platform is based on accepting patches to projects. So I don't know what your experience is, but it sure is not the same as my experience. AndrewC: Dependent on the license they chose for their code. As I said above, I can let you see my code and compile it for yourself, or even modify it for yourself, but I can disallow you distributing said code. Now, would some tech-savy users be able to compile the base + your changes? Sure. Would the mass majority of people be able to? No.
Yes, it depends on the license, but as mentioned earlier if it's using a non-free non-OSI license, it's not very interesting and we might as well not even talk about any contributions or modifications at all.